chore: use cfg! to instead of #cfg[] for jemalloc control policy #12307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangrunji0408
approved these changes
Sep 14, 2023
Codecov Report
@@ Coverage Diff @@
## main #12307 +/- ##
==========================================
- Coverage 69.94% 69.94% -0.01%
==========================================
Files 1411 1411
Lines 235298 235306 +8
==========================================
- Hits 164581 164579 -2
- Misses 70717 70727 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
BTW, I plan to enable jemalloc on macOS after your dashboard PR, because it's better than nothing |
Li0k
pushed a commit
that referenced
this pull request
Sep 15, 2023
Little-Wallace
added a commit
that referenced
this pull request
Sep 18, 2023
commit c82fc9c Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Sep 18 08:37:33 2023 +0000 chore(deps): Bump chrono from 0.4.30 to 0.4.31 (#12359) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Runji Wang <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Runji Wang <[email protected]> Co-authored-by: TennyZhuang <[email protected]> commit cbdc1ac Author: Huangjw <[email protected]> Date: Mon Sep 18 16:22:35 2023 +0800 chore(ci): move release jobs to main-cron pipeline (#12339) commit b37a19c Author: Yuhao Su <[email protected]> Date: Mon Sep 18 16:18:01 2023 +0800 feat(dashboard): add memory profiling (#12052) commit 71d8170 Author: TennyZhuang <[email protected]> Date: Mon Sep 18 15:58:26 2023 +0800 refactor(expr): allow defining functions in frontend (#12287) Signed-off-by: TennyZhuang <[email protected]> Co-authored-by: zwang28 <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit cedaec9 Author: Dylan <[email protected]> Date: Mon Sep 18 15:54:10 2023 +0800 feat(optimizer): support agg group by simplify rule (#12349) commit 71d9b0b Author: Noel Kwan <[email protected]> Date: Mon Sep 18 15:32:00 2023 +0800 feat(meta): update StreamJob status on finish (#12342) commit 784fe56 Author: zwang28 <[email protected]> Date: Mon Sep 18 14:47:49 2023 +0800 fix(backup): ensure correct delta log order (#12371) commit 711ecd5 Author: congyi wang <[email protected]> Date: Mon Sep 18 14:11:24 2023 +0800 feat(state_table): add iterator sub range under a certain pk prefix (#12251) commit 1877aed Author: xiangjinwu <[email protected]> Date: Mon Sep 18 13:49:15 2023 +0800 refactor(sink): impl SinkFormatter for AppendOnly and Upsert (#12321) commit f304ed2 Author: xxchan <[email protected]> Date: Sun Sep 17 20:20:17 2023 +0800 revert: Revert "chore: add platforms to hakari (#12333)" (#12363) commit a975d93 Author: Bohan Zhang <[email protected]> Date: Sun Sep 17 19:04:24 2023 +0800 fix: handle kafka sink message timeout error (#12350) commit 8ef74ad Author: Runji Wang <[email protected]> Date: Sat Sep 16 12:16:02 2023 +0800 fix(udf): handle visibility of input chunks in UDTF (#12357) Signed-off-by: Runji Wang <[email protected]> commit 31fdc26 Author: Xu <[email protected]> Date: Fri Sep 15 21:01:14 2023 -0400 feat(expr): switch to `fancy-regex` crate & update the original version (#12329) Co-authored-by: xzhseh <[email protected]> commit 0032145 Author: Runji Wang <[email protected]> Date: Fri Sep 15 16:57:25 2023 +0800 refactor(expr): support variadic function in `#[function]` macro (#12178) Signed-off-by: Runji Wang <[email protected]> commit 467ba4b Author: stonepage <[email protected]> Date: Fri Sep 15 16:28:13 2023 +0800 fix: stream backfill executor use correct schema (#12314) Co-authored-by: Noel Kwan <[email protected]> commit c443197 Author: Dylan <[email protected]> Date: Fri Sep 15 16:22:13 2023 +0800 feat(optimizer): support correlated column in order by (#12341) commit 8a36ca3 Author: Noel Kwan <[email protected]> Date: Fri Sep 15 16:11:03 2023 +0800 feat(meta): Add `creating_status` field for stream jobs (#12330) commit bf5b14e Author: zwang28 <[email protected]> Date: Fri Sep 15 16:06:17 2023 +0800 chore: lift decoding message size limit for ddl client (#12340) commit c0060b2 Author: zwang28 <[email protected]> Date: Fri Sep 15 15:32:14 2023 +0800 feat(meta): add hummock config relevant tables to rw_catalog (#12337) commit 59bb645 Author: xxchan <[email protected]> Date: Fri Sep 15 14:54:54 2023 +0800 chore: add platforms to hakari (#12333) Signed-off-by: Runji Wang <[email protected]> Co-authored-by: Runji Wang <[email protected]> commit 7baa27f Author: Bugen Zhao <[email protected]> Date: Fri Sep 15 14:00:14 2023 +0800 chore: split full debug info for release build (#12255) Signed-off-by: Bugen Zhao <[email protected]> commit a99e6f3 Author: Richard Chien <[email protected]> Date: Fri Sep 15 13:58:19 2023 +0800 fix(stream): fix pk indices of GroupTopN executors (#12304) Signed-off-by: Richard Chien <[email protected]> commit 43c010e Author: Croxx <[email protected]> Date: Fri Sep 15 11:59:41 2023 +0800 chore: fix comment and metrics (#12331) Signed-off-by: MrCroxx <[email protected]> commit 214118b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Sep 15 10:03:14 2023 +0800 chore(deps): Bump serde_json from 1.0.106 to 1.0.107 (#12322) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 41ebb2a Author: Xu <[email protected]> Date: Thu Sep 14 22:02:08 2023 -0400 fix(regexp): substraction overflow when incorrectly speicifying `start` (#12325) commit a566cfe Author: Xu <[email protected]> Date: Thu Sep 14 12:58:35 2023 -0400 feat(expr): add `array_sum` (#12162) Signed-off-by: Runji Wang <[email protected]> Co-authored-by: Runji Wang <[email protected]> commit 28bbf10 Author: Croxx <[email protected]> Date: Fri Sep 15 00:40:27 2023 +0800 fix(ci): exclude tikv-jemalloc-sys in hakari check (#12320) Signed-off-by: MrCroxx <[email protected]> commit 5aa5a47 Author: zwang28 <[email protected]> Date: Thu Sep 14 21:02:01 2023 +0800 feat(meta): add hummock version relevant tables to rw_catalog (#12309) commit a740364 Author: Huangjw <[email protected]> Date: Thu Sep 14 19:11:04 2023 +0800 chore(ci): install locales in prebuilt image (#12311) Signed-off-by: Bugen Zhao <[email protected]> Co-authored-by: Bugen Zhao <[email protected]> commit 0e72056 Author: StrikeW <[email protected]> Date: Thu Sep 14 18:42:34 2023 +0800 refactor(jdbc-sink): execute statements in batch and set isolation level to RC (#12250) commit 827ed5e Author: Dylan <[email protected]> Date: Thu Sep 14 17:31:41 2023 +0800 refactor(connector): migrate cdc source metric from connector to compute (#12283) commit a934185 Author: Dylan <[email protected]> Date: Thu Sep 14 17:31:04 2023 +0800 fix(optimizer): relax scan predicate pull up mapping inverse restriction (#12308) commit db0c099 Author: Dylan <[email protected]> Date: Thu Sep 14 17:30:28 2023 +0800 feat(stream): handling watermark in temporal join (#12302) commit 1ecea63 Author: Bugen Zhao <[email protected]> Date: Thu Sep 14 16:43:14 2023 +0800 refactor(risedev): split the steps for building and running playground (#12279) Signed-off-by: Bugen Zhao <[email protected]> Co-authored-by: xxchan <[email protected]> commit ae4b1f8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Sep 14 08:41:29 2023 +0000 chore(deps): Bump clap from 4.4.2 to 4.4.3 (#12245) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bugen Zhao <[email protected]> commit 7ca370a Author: Croxx <[email protected]> Date: Thu Sep 14 16:24:19 2023 +0800 feat(refill): fetch whole sst file when refilling (#12265) Signed-off-by: MrCroxx <[email protected]> commit ec129b6 Author: Yuhao Su <[email protected]> Date: Thu Sep 14 16:04:37 2023 +0800 chore: use cfg! to instead of #cfg[] for jemalloc control policy (#12307) commit 9814af8 Author: Runji Wang <[email protected]> Date: Thu Sep 14 14:45:14 2023 +0800 feat(expr): add `pg_sleep` function (#12294) Signed-off-by: Runji Wang <[email protected]> commit 4525e67 Author: Noel Kwan <[email protected]> Date: Thu Sep 14 14:38:03 2023 +0800 feat(stream): support source throttling (#12295) commit 5ffd58d Author: Dylan <[email protected]> Date: Thu Sep 14 14:35:03 2023 +0800 refactor(connector): replace validate source rpc with jni (#12270) commit 888f2dd Author: Eric Fu <[email protected]> Date: Thu Sep 14 14:32:59 2023 +0800 fix: panic when dumping memory profile (#12276) Signed-off-by: Little-Wallace <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Make it more friendly for development. IDE will not hide code on non-linux env.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.